SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.0
Threshold is low
Effort is max
Summary
Classes |
Bugs |
Errors |
Missing Classes |
9 |
11 |
0 |
0 |
it.tidalwave.northernwind.frontend.springmvc.SpringMvcRestController
Bug |
Category |
Details |
Line |
Priority |
Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.northernwind.frontend.springmvc.SpringMvcRestController(). |
MALICIOUS_CODE |
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR |
46 |
Low |
Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.northernwind.frontend.springmvc.SpringMvcRestController(). |
MALICIOUS_CODE |
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR |
46 |
Low |
Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.northernwind.frontend.springmvc.SpringMvcRestController() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
46 |
Medium |
Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.northernwind.frontend.springmvc.SpringMvcRestController() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
46 |
Low |
it.tidalwave.northernwind.frontend.springmvc.ThreadNameChangerAspect
Bug |
Category |
Details |
Line |
Priority |
it.tidalwave.northernwind.frontend.springmvc.ThreadNameChangerAspect.ajc$perSingletonInstance isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
|
Low |
it.tidalwave.northernwind.frontend.ui.component.rssfeed.DefaultRssFeedViewController
Bug |
Category |
Details |
Line |
Priority |
new it.tidalwave.northernwind.frontend.ui.component.rssfeed.DefaultRssFeedViewController(RssFeedView, SiteNode, SiteProvider, RequestLocaleManager) may expose internal representation by storing an externally mutable object into DefaultRssFeedViewController.view |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
93 |
Medium |
it.tidalwave.northernwind.frontend.ui.component.rssfeed.htmltemplate.HtmlTemplateRssFeedView
Bug |
Category |
Details |
Line |
Priority |
Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.northernwind.frontend.ui.component.rssfeed.htmltemplate.HtmlTemplateRssFeedView(Id). |
MALICIOUS_CODE |
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR |
54 |
Low |
it.tidalwave.northernwind.frontend.ui.springmvc.SpringMvcSiteView
Bug |
Category |
Details |
Line |
Priority |
Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.northernwind.frontend.ui.springmvc.SpringMvcSiteView(). |
MALICIOUS_CODE |
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR |
58 |
Low |
Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.northernwind.frontend.ui.springmvc.SpringMvcSiteView(). |
MALICIOUS_CODE |
MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR |
58 |
Low |
Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.northernwind.frontend.ui.springmvc.SpringMvcSiteView() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
58 |
Medium |
Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.northernwind.frontend.ui.springmvc.SpringMvcSiteView() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
58 |
Low |